@adam-fowler I'm not sure what expected behaviour would be here.

If they are flagged as pending they are already in the queue, so this should be unnecessary and might even cause issues. @thoven87 Is this change to fix an issue you are seeing

If they are flagged as pending they are already in the queue, so this should be unnecessary and might even cause issues. @thoven87 Is this change to fix an issue you are seeing

I don't see the potential issue this could cause if when a job gets picked up, it's locked by it's worker.

Another issue I see after running countless of tests is with the onMinutes schedule. (which is off topic from this PR) Say you have at least two jobs with the exact same schedule. Only the first job will get run the second job will say it's next schedule if for the current running schedule and will keep pushing jobs with pending states. Since, these jobs are not registered in the JobController, they are registered in scheduled job controller, they will keep queueing and stay there. I will explain more in Discord. I know @Joannis had some strong options when I first bought this potential issue. I would love to hear some of your thoughts. The way I have some this issue in past, is by introducing a small random delay with each scheduled task before triggering. (I will open a ticket separately for this issue)

@adam-fowler I'm not sure what expected behaviour would be here.

Job with pending states should be run if pendingJobInitialization is set to re-run the Redis implementation has no such limit. cc @adam-fowler

if pendingJobsInitialization = .rerun is unnecessary, should be removed from the configuration options?

if pendingJobsInitialization = .rerun is unnecessary, should be removed from the configuration options?

I guess we could add another enum, that just has cases doNothing, remove

if pendingJobsInitialization = .rerun is unnecessary, should be removed from the configuration options?

I guess we could add another enum, that just has cases doNothing, remove

The enum definition has such cases already and the default state is to do nothing